Update README.md #191
Merged
Update README.md #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uselessnaming
approved these changes
Dec 6, 2024
Collaborator
|
맞아요.. MVI라고 하기에는 이벤트를 통해서만 상태가 변경된다는 것에 맞지 않는 것 같고, MVVM이라고 하기에는 MVI로 넘어가는 도중인 느낌인 상태인 것 같아요.. |
LeeYongIn0517
added a commit
that referenced
this pull request
Dec 15, 2024
* commit '0a1600e176d082cf483ddfd2eee772fcc813e20c': Update README.md (#191) release, master와 conflict 없앤 1.1.4 버전입니다 (#188) Feature/hbti HBTI 서비스 완성 (#187) # Conflicts: # feature-hbti/src/test/java/com/hmoa/feature_hbti/HbtiSurveyViewModelTest.kt # feature-hbti/src/test/java/com/hmoa/feature_hbti/NotePickViewmodelTest.kt # feature-home/src/main/java/com/hmoa/feature_home/viewmodel/HomeViewModel.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@uselessnaming
리드미에 아래처럼 MVVM적용이라고 표기된 게 오해의 소지가 있을 수 있고
model로 표시한 범주도 잘못된 거 같아서 수정했습니다.
처음에는 MVVM식으로 하려고 했는데 저희가 참고한 stateFlow 방식이 뭔가 MVI이랑 비슷하다보니 단방향 데이터흐름으로 가긴했는데
막상 MVI라고 하기에는 MVI의 I(Intent)가 없는
뭔가 MVVM이랑 MVI도 아닌 모호한..그런 상태같아요 그쵸???