Refactor/magazine #204
Merged
Refactor/magazine #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@uselessnaming |
Collaborator
Author
|
오잉 저는 merge가 되는 것으로 보이는데 혹시 다른가요?? |
…refactor/magazine
Collaborator
Author
|
용인님 머지까지 합쳐서 다시 build 중인 것 같습니당 |
LeeYongIn0517
added a commit
that referenced
this pull request
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@LeeYongIn0517
Refactor 완료
Report를 참고해서 Skippable이 아닌 것 위주로 변경했고, 전반적으로는 수정이 완료되었습니다
다만 아직 각각의 dto에 대한 stable 작업이 안되어있어서 skippable로 처리할 수 없는 경우들이 있는데 이 부분은 오늘 회의에서 정하면 좋을 것 같아요!