Speedup spec all #1625
Open
Speedup spec all #1625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think why reusing the set from hyp_frees is slower is that the vars from strip_forall is already guaranteed to be fresh in the term and that sorting the list makes it so that the loop check here https://github.com/HOL-Theorem-Prover/HOL/blob/24e40cd1c7f7e235a5c9f32f692c0d9ae04ddb2b/src/0/Term.sml#L345C1-L347C25 is slower |
|
note time from docker-ci stdknl 3076.5s |
Note that reusing set from hyp_frees is actually slower. times using `time bin/build` before real 10m37.510s user 21m43.869s sys 3m12.949s reusing set from hyp_frees real 10m40.847s user 21m49.628s sys 3m16.913s without reusing set from hyp_frees real 10m29.285s user 21m9.849s sys 3m10.606s
ordinarymath
force-pushed
the
speedup_SPEC_ALL
branch
from
92d99f1 to
f3101b2
Compare
|
I wanted to see if I could speed it up even more by using gen_variant with a predicate check but the issue is that you can't lookup a string using the HOLset produced by FVL and recreating a new set is slower. #1642 is going to be needed for the further improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that reusing set from hyp_frees is actually slower.
times using
time bin/buildbefore
real 10m37.510s
user 21m43.869s
sys 3m12.949s
reusing set from hyp_frees
real 10m40.847s
user 21m49.628s
sys 3m16.913s
without reusing set from hyp_frees
real 10m29.285s
user 21m9.849s
sys 3m10.606s
note depends on #1623