Replace many save_thm
instances with Theorem
in src
#1682
+1,561
−1,744
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally, a PR with a much more reasonable size :)
I've also manually removed some instances of
save_thm
, which were either behind amap
or within alocal
orlet
.In general, I don't think much is gained from using
map save_thm
instead of usingTheorem
.Regarding
local
,Theorem
s right before the end need a;
, otherwiseunquote
seems to get confused on where its end is, leading to syntax problems.If
let
is used on the right-hand side ofTheorem
, it seems that it is necessary to parenthesize it.