-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor logit models #539
Conversation
Improve variable naming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this change affect results in both agent modelling and normal modelling? I ran the small test network with olusanya
branch and this branch using normal model run and the results were different. Is it on purpose or by accident?
That is strange. Yes, the calculation of the log variables is changed, but it gives the same results according to the integration tests. 😮 |
Could this branch be slightly out-of-date compared to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay.
This PR changes the the way the mode choices are done in agent simulations. Instead of Monte Carlo choices, the choices are based on direct utility maximization including an individual error term. The logic behind this is described in
EXT-MAL 2023/Vaikutusten arviointi/Menetelmäkehitys/agenttimallinnus
. Destination choices are still done with Monte Carlo simulation, because direct utility maximization is slow with so many alternatives to compare.The pros of this change: