Allow MRIs specification #82
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilshoffmann
requested changes
Dec 10, 2025
Member
nilshoffmann
left a comment
nilshoffmann
left a comment
There was a problem hiding this comment.
Thank you for the suggestion. Just some minor comments to ensure alignment with the file type for ms_runs.
| ==== ms_run[1-n]-usi_identifier | ||
| [cols=",",] | ||
| |=================================================================================================================================================================== | ||
| |*Description* |An identifier for the MS run based on the Universal Spectrum Identifier (USI) specification. |
Member
There was a problem hiding this comment.
Please add the link to the standard: https://www.psidev.info/usi
| |=================================================================================================================================================================== | ||
| |*Description* |An identifier for the MS run based on the Universal Spectrum Identifier (USI) specification. | ||
| Implied within the USI is an MS run identifier. Every deposited MS run can be referenced with a shortened form: `mzspec:<collection>:<msRun>`. | ||
| Since an MS run may be represented in several formats (with potentially slightly different data associated with the spectrum), a format suffix MAY be specified (e.g. `mzspec:<collection>:<msRun>.RAW`) to signify that a specific file type is meant. |
Member
There was a problem hiding this comment.
If specified, the format suffix should align with the ms_run[1-n]-format parameter and the ms_run[1-n]-location suffix defined in the metadata section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #18