added mobile friendly nav bar#18
Open
nathan-tang wants to merge 1 commit intomasterfrom
Open
Conversation
Member
|
Hype!! I'll take a look at this later tonight. In the meantime, I'm also adding @taesungh as a reviewer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
react-iconspackage for icons. Might be useful for future ui updates so we don't have to download svg each time.Demo of it in action:
Right now there's no media query to detect mobile mode so it's always going to have the hamburger menu button on the side.
That's a quick fix though, mostly up to preference.
Not completely sure if this solves Issue#13 but it does help navigate the site!