refactor: font weight, button component props

HackAtUCI · Nov 5, 2023 · 9cf447c · 9cf447c
1 parent 32dad9a
commit 9cf447c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 11 deletions.
diff --git a/apps/site/src/app/(home)/sections/Landing/Landing.tsx b/apps/site/src/app/(home)/sections/Landing/Landing.tsx
@@ -10,7 +10,6 @@ const Landing = () => {
 				<Button
 					text="Stay updated"
 					href="https://uci.us13.list-manage.com/subscribe?u=5976872928cd5681fbaca89f6&id=93333e11eb"
-					isLink
 				/>
 			</div>
 		</section>

diff --git a/apps/site/src/app/globals.css b/apps/site/src/app/globals.css
@@ -16,7 +16,7 @@ body {
 
 h1 {
 	font-size: calc(30px + 2vw);
-	font-weight: bold;
+	font-weight: 700;
 }
 
 p {
@@ -26,5 +26,5 @@ p {
 
 a {
 	font-size: calc(13px + 1vw);
-	font-weight: bold;
+	font-weight: 700;
 }
diff --git a/apps/site/src/components/Button/Button.tsx b/apps/site/src/components/Button/Button.tsx
@@ -3,11 +3,10 @@ import styles from "./Button.module.css";
 interface ButtonProps {
 	text: string;
 	href?: string;
-	isLink: boolean;
 }
 
-const Button: React.FC<ButtonProps> = ({ text, href, isLink }) => {
-	if (isLink) {
+const Button: React.FC<ButtonProps> = ({ text, href }) => {
+	if (href) {
 		return (
 			<a
 				href={href}
@@ -20,11 +19,9 @@ const Button: React.FC<ButtonProps> = ({ text, href, isLink }) => {
 		);
 	}
 	return (
-		<input
-			type="submit"
-			className={styles.button + " font-body"}
-			value={text}
-		/>
+		<button type="submit" className={styles.button + " font-body"}>
+			{text}
+		</button>
 	);
 };
-Original file line number
+Diff line change
@@ Expand Up / @@ -10,7 +10,6 @@ const Landing = () => { @@
     				<Button
     					text="Stay updated"
     					href="https://uci.us13.list-manage.com/subscribe?u=5976872928cd5681fbaca89f6&id=93333e11eb"
-    					isLink
     				/>
     			</div>
     		</section>
@@ Expand Down @@