Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up about section #17

Merged
merged 10 commits into from
Nov 25, 2023
Merged

Set up about section #17

merged 10 commits into from
Nov 25, 2023

Conversation

samderanova
Copy link
Contributor

This creates the about section for the new IrvineHacks site. One issue is that unlike in the Figma, there is no clear transition between the landing and this new section.

@samderanova samderanova linked an issue Nov 12, 2023 that may be closed by this pull request
@samderanova samderanova requested a review from a team November 12, 2023 00:15
Copy link
Contributor

github-actions bot commented Nov 12, 2023

Deploy preview for irvinehacks-site-2024 ready!

Name IrvineHacks 2024 Site
Preview Visit Preview
Commit bb549ba

Copy link
Contributor

github-actions bot commented Nov 12, 2023

Deploy preview for irvinehacks-site-2024-sanity ready!

Name Sanity Studio
Preview Visit Preview
Commit bb549ba

Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start, one issue with the background art and a suggestion about asset compression along with other smaller notes.

apps/site/src/assets/backgrounds/water.png Outdated Show resolved Hide resolved
apps/site/src/app/(home)/sections/About/About.tsx Outdated Show resolved Hide resolved
apps/site/src/app/(home)/sections/About/About.tsx Outdated Show resolved Hide resolved
apps/site/src/app/(home)/sections/About/About.tsx Outdated Show resolved Hide resolved
apps/site/src/app/(home)/sections/Landing/Landing.tsx Outdated Show resolved Hide resolved
@njhuey njhuey mentioned this pull request Nov 20, 2023
@samderanova samderanova requested review from a team and taesungh and removed request for taesungh November 25, 2023 03:38
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding.
Note for later: vertical padding between sections could be improved.

@samderanova samderanova merged commit d27dd6a into main Nov 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up about section
2 participants