Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup FAQ #23

Merged
merged 14 commits into from
Nov 26, 2023
Merged

Setup FAQ #23

merged 14 commits into from
Nov 26, 2023

Conversation

waalbert
Copy link
Contributor

No description provided.

@waalbert waalbert linked an issue Nov 18, 2023 that may be closed by this pull request
Set up FAQ section #15
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 18, 2023 •
edited
Loading

Deploy preview for irvinehacks-site-2024-sanity ready!

Name Sanity Studio
Preview Visit Preview
Commit 554ae42

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 19, 2023 •
edited
Loading

Deploy preview for irvinehacks-site-2024 ready!

Name IrvineHacks 2024 Site
Preview Visit Preview
Commit 554ae42

samderanova
samderanova requested changes Nov 19, 2023
View reviewed changes
Copy link
Contributor

@samderanova samderanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this! A few things to point out:

apps/site/src/app/(home)/page.tsx Outdated Show resolved Hide resolved
apps/site/src/app/(home)/page.tsx Outdated Show resolved Hide resolved
apps/site/src/app/(home)/page.tsx Outdated Show resolved Hide resolved
apps/site/src/app/(home)/sections/FAQ/FAQ.module.scss Outdated Show resolved Hide resolved
apps/site/src/assets/backgrounds/faq-background-mobile.svg Outdated Show resolved Hide resolved
samderanova
samderanova requested changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@samderanova samderanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few very small nitpicks, but otherwise, it looks good!

apps/site/src/app/(home)/sections/FAQ/FAQ.tsx Outdated Show resolved Hide resolved
apps/site/src/lib/components/Accordion/Accordion.module.scss Outdated Show resolved Hide resolved
samderanova
samderanova requested changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@samderanova samderanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nitpicks here, but looks good otherwise:

apps/site/src/app/(home)/sections/FAQ/FAQ.tsx Show resolved Hide resolved
apps/site/src/app/(home)/sections/FAQ/FAQAccordion.tsx Outdated Show resolved Hide resolved
apps/site/src/app/(home)/sections/FAQ/getQuestions.ts Outdated Show resolved Hide resolved
apps/site/src/lib/sanity/client.ts Outdated Show resolved Hide resolved
apps/site/src/app/(home)/sections/FAQ/FAQ.tsx Outdated Show resolved Hide resolved
samderanova
samderanova reviewed Nov 25, 2023
View reviewed changes
Copy link
Contributor

@samderanova samderanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for finishing this.

Issue: The bottom of the landing page background is white, but is supposed to be transparent. See #36 for details. #37 resolves this issue.

samderanova
samderanova approved these changes Nov 25, 2023
View reviewed changes
Copy link
Contributor

@samderanova samderanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash during merge.

@waalbert waalbert merged commit 54fe3d4 into main Nov 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samderanova samderanova samderanova approved these changes

@alexanderl19 alexanderl19 Awaiting requested review from alexanderl19

@taesungh taesungh Awaiting requested review from taesungh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up FAQ section
4 participants
@waalbert @samderanova @alexanderl19 @taesungh