Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fog animation #28

Merged
merged 3 commits into from
Nov 22, 2023
Merged

feat: fog animation #28

merged 3 commits into from
Nov 22, 2023

Conversation

samderanova
Copy link
Contributor

This adds a native CSS fog animation to the landing section. See #27 for more details.

@samderanova samderanova linked an issue Nov 22, 2023 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Nov 22, 2023

Deploy preview for irvinehacks-site-2024-sanity ready!

Name Sanity Studio
Preview Visit Preview
Commit 05caf20

Copy link
Contributor

github-actions bot commented Nov 22, 2023

Deploy preview for irvinehacks-site-2024 ready!

Name IrvineHacks 2024 Site
Preview Visit Preview
Commit 05caf20

@tyleryy
Copy link
Contributor

tyleryy commented Nov 22, 2023

Fog animation has horizontal overflow.
Screen Shot 2023-11-22 at 12 47 31 AM

@tyleryy
Copy link
Contributor

tyleryy commented Nov 22, 2023

I think it looks good, but just a suggestion that you don't have to take--you can use clouds from react three fiber (ref). And then for the animation you can either move the clouds or the camera. You can also maybe make the fog really faint and have it sit on the whole page like a foggy day. Might pair well with fireflies and theme aesthetically and technically since we are already using WebGL. This is a design aspect and not essential, so how it is now is also good.

@samderanova
Copy link
Contributor Author

Interesting! The clouds look cool, but I'm not sure if they really match with the current theme. I also just resolved the horizontal overflow by disabling it.

@tyleryy
Copy link
Contributor

tyleryy commented Nov 22, 2023

Oh the clouds are actually multiple of that component on top each other. So u can just remove the layers and make it flat and then adjust opacity or whatever props are in that component to make it look like fog.

@tyleryy
Copy link
Contributor

tyleryy commented Nov 22, 2023

Also another idea, in another PR, do u want to make this a whileInView scroll animation? Like user scrolls and the fog separates as the scroll down?

@samderanova
Copy link
Contributor Author

I don't think that would be good in terms of user experience because if someone want to view the content on the landing screen, they would have to scroll in order to do so and by then, the landing would be out of view.

@samderanova samderanova merged commit f978154 into main Nov 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Landing Page Animation C: Fog
2 participants