feat: Displaying void message for applicants who failed to RSVP on time#289
Merged
RandyHuynh5815 merged 3 commits intomainfrom Jan 21, 2024
Merged
feat: Displaying void message for applicants who failed to RSVP on time#289RandyHuynh5815 merged 3 commits intomainfrom
RandyHuynh5815 merged 3 commits intomainfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
Deploy preview for irvinehacks-site-2024 ready!
|
samderanova
requested changes
Jan 20, 2024
Contributor
samderanova
left a comment
samderanova
left a comment
There was a problem hiding this comment.
Thanks for the quick work on this! A few suggestions:
samderanova
previously approved these changes
Jan 20, 2024
waalbert
previously approved these changes
Jan 21, 2024
RandyHuynh5815
dismissed stale reviews from waalbert and samderanova
via
ef5b242
RandyHuynh5815
force-pushed
the
feat/void-message
branch
from
075026d to
ef5b242
Compare
samderanova
requested changes
Jan 21, 2024
Contributor
samderanova
left a comment
samderanova
left a comment
There was a problem hiding this comment.
Not sure if you saw a merge conflict regarding the Button component, but currently the RSVP button causes horizontal overflow on mobile views. See Button.tsx from #283.
samderanova
approved these changes
Jan 21, 2024
Contributor
samderanova
left a comment
samderanova
left a comment
There was a problem hiding this comment.
My mistake, seems like I didn't pull the changes properly. Looks good!
waalbert
approved these changes
Jan 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #281. Added display message and XCircle to applicants with the
VOIDstatus in the RSVP component as well as the two new statusesACCEPTEDandVOID. Verdict and submission components remain, but the waiver component is removed. Unsure if the language used for the display message would fit both scenarios mentioned well.