Fix NEXT_PUBLIC_ environment variables in cache
#291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Deploy preview for irvinehacks-site-2024 ready!
|
taesungh
force-pushed
the
fix/site-build-cache-env-var
branch
from
d6a3081
to
469caa3
Compare
- Replace `NEXT_PUBLIC_VERCEL_URL` with `VERCEL_URL` to avoid inlining - Add `NEXT_PUBLIC_SANITY_*` to Turborepo `pipeline.build.env` cache key
taesungh
force-pushed
the
fix/site-build-cache-env-var
branch
from
469caa3
to
b8b5693
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #290.
Changes
NEXT_PUBLIC_VERCEL_URLwithVERCEL_URLto avoid inliningNEXT_PUBLIC_SANITY_*to Turborepopipeline.build.envcache keyTesting
Confirm deployment logs show that server-side API calls are going to the current deployment, even when the site build was from Full Turbo cache.