Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Resources Page #305

Merged
merged 9 commits into from
Jan 26, 2024
Merged

Feature: Resources Page #305

merged 9 commits into from
Jan 26, 2024

Conversation

alexanderl19
Copy link
Contributor

closes #196 #197

@alexanderl19 alexanderl19 linked an issue Jan 21, 2024 that may be closed by this pull request
@alexanderl19 alexanderl19 requested a review from a team January 21, 2024 03:14
Copy link
Contributor

github-actions bot commented Jan 21, 2024

Deploy preview for irvinehacks-site-2024 ready!

Name IrvineHacks 2024 Site
Preview Visit Preview
Commit 26fe1a9

Copy link
Contributor

@samderanova samderanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start so far! A few things to note:

apps/site/src/app/(main)/resources/page.tsx Outdated Show resolved Hide resolved
apps/site/src/app/(main)/resources/page.tsx Outdated Show resolved Hide resolved
samderanova
samderanova previously approved these changes Jan 21, 2024
Copy link
Contributor

@samderanova samderanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now. We can refactor the Button component in a separate issue. Thanks for the quick work on this!

@waalbert
Copy link
Contributor

image

Resources is a bit off centered on my iPhone 13 mini Safari

samderanova
samderanova previously approved these changes Jan 25, 2024
Copy link
Contributor

@samderanova samderanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to push one more small change to include the home and resources links in the navbar, but other than that, looks good!

waalbert
waalbert previously approved these changes Jan 25, 2024
@samderanova samderanova dismissed stale reviews from waalbert and themself via 26fe1a9 January 26, 2024 02:33
@samderanova samderanova merged commit 3568acb into main Jan 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create resource card component Write GROQ query to pull resources and organize them into their categories
3 participants