Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update/removed review access after release #353

Closed
wants to merge 2 commits into from

Conversation

RandyHuynh5815
Copy link
Contributor

Resolves #330. Review POST route commented out to ensure no accidental review changes after decisions were released. However, the front end still has the review page and button to review.

Copy link
Contributor

github-actions bot commented Jan 25, 2024

Deploy preview for irvinehacks-site-2024 ready!

Name IrvineHacks 2024 Site
Preview Visit Preview
Commit 78d1596

@RandyHuynh5815 RandyHuynh5815 requested a review from a team January 25, 2024 18:12
@taesungh
Copy link
Member

@samderanova, I don't think we need to actually remove this endpoint, could just ungrant reviewer role?

Copy link
Contributor

@samderanova samderanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies, I believe I told @RandyHuynh5815 to comment out the route, but yes, it's enough to just remove Role.REVIEWER in the Depends.

@taesungh
Copy link
Member

taesungh commented Aug 4, 2024

I meant from the individual users, not the route itself, but closing as no longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Admin] Applicants can be reviewed even after release
3 participants