Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add confirm attendance route for non-hackers #362

Merged
merged 1 commit into from
Jan 26, 2024
Merged

feat: add confirm attendance route for non-hackers #362

merged 1 commit into from
Jan 26, 2024

Conversation

njhuey
Copy link
Contributor

@njhuey njhuey commented Jan 26, 2024

Resolves #322

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 26, 2024 •
edited
Loading

Deploy preview for irvinehacks-site-2024 ready!

Name IrvineHacks 2024 Site
Preview Visit Preview
Commit 699764d

@njhuey njhuey force-pushed the feature/non-hacker-attending branch from 14ce00c to 13a0b88 Compare January 26, 2024 08:01
taesungh
taesungh reviewed Jan 26, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work so far, one issue/typo and one suggestion on logging.

apps/api/src/admin/participant_manager.py Outdated Show resolved Hide resolved
apps/api/src/routers/admin.py Outdated Show resolved Hide resolved
@njhuey njhuey force-pushed the feature/non-hacker-attending branch from 13a0b88 to 5457393 Compare January 26, 2024 18:57
@njhuey njhuey requested a review from taesungh January 26, 2024 18:57
taesungh
taesungh previously approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this.

@njhuey njhuey force-pushed the feature/non-hacker-attending branch from 5457393 to 699764d Compare January 26, 2024 19:02
@taesungh taesungh changed the title feat: add update attending route for non-hackers feat: add confirm attendance route for non-hackers Jan 26, 2024
@taesungh taesungh merged commit 8851229 into main Jan 26, 2024
4 checks passed
@taesungh taesungh mentioned this pull request Jan 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@taesungh taesungh taesungh approved these changes

@samderanova samderanova samderanova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API] Add Admin endpoint for directors to confirm attendance of a non-hacker
3 participants
@njhuey @samderanova @taesungh