Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirm non-hacker attendance from PMS #368

Merged
merged 4 commits into from
Jan 26, 2024
Merged

Confirm non-hacker attendance from PMS #368

merged 4 commits into from
Jan 26, 2024

Conversation

samderanova
Copy link
Contributor

Resolves #356.

Changes

@samderanova samderanova linked an issue Jan 26, 2024 that may be closed by this pull request
[PMS] Include confirm attendance option for non-hackers #356
Closed
@samderanova samderanova requested review from taesungh and a team January 26, 2024 20:59
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 26, 2024 •
edited
Loading

Deploy preview for irvinehacks-site-2024 ready!

Name IrvineHacks 2024 Site
Preview Visit Preview
Commit 9431dad

taesungh
taesungh requested changes Jan 26, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start, need to account for other cases with confirm button.

apps/site/src/lib/admin/useParticipants.ts Outdated Show resolved Hide resolved
apps/site/src/app/admin/participants/components/ParticipantAction.tsx Show resolved Hide resolved
apps/site/src/lib/admin/authorization.ts Show resolved Hide resolved
@samderanova samderanova requested review from taesungh and a team January 26, 2024 21:22
@taesungh taesungh changed the title Confirm non-hacker attendance Confirm non-hacker attendance from PMS Jan 26, 2024
taesungh
taesungh approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for now. Separate issue for the default REVIEWED status used in #366.

@samderanova samderanova merged commit 5f9019c into main Jan 26, 2024
4 checks passed
@taesungh taesungh mentioned this pull request Jan 26, 2024
Closed
@samderanova samderanova mentioned this pull request Jan 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waalbert waalbert waalbert approved these changes

@taesungh taesungh taesungh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PMS] Include confirm attendance option for non-hackers
3 participants
@samderanova @taesungh @waalbert