Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separated landing background pictures #40

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

samderanova
Copy link
Contributor

@samderanova samderanova commented Nov 26, 2023

Resolves #30 . There's a slight issue where on larger viewpoints, the background (and thus, the color transition to the deep blue) get cut off. I'm currently trying to figure out how to fix this.

@samderanova samderanova linked an issue Nov 26, 2023 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Nov 26, 2023

Deploy preview for irvinehacks-site-2024-sanity ready!

Name Sanity Studio
Preview Visit Preview
Commit f6033dd

Copy link
Contributor

github-actions bot commented Nov 26, 2023

Deploy preview for irvinehacks-site-2024 ready!

Name IrvineHacks 2024 Site
Preview Visit Preview
Commit f6033dd

@samderanova samderanova marked this pull request as ready for review November 27, 2023 05:09
@samderanova samderanova requested a review from a team November 27, 2023 05:09
Copy link
Contributor

@waalbert waalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taesungh
Copy link
Member

taesungh commented Dec 6, 2023

I'm not seeing the benefit to the layered approach here: I thought the long term goal was having dynamic positioning of the pieces, but this stacked background doesn't make progress towards that. Mainly pointing this out since the asset size has dramatically increased to produce nearly the same end result.

@samderanova
Copy link
Contributor Author

This is so we can eventually add on animations more easily. One of the animations, for example, is to have the boat slide up into the landing section on load.

@taesungh
Copy link
Member

taesungh commented Dec 6, 2023

Hmm, animating the background position when there are so many backgrounds might be a bit cumbersome. Additionally, I thought the movement concepts would require some scroll-based parallax which wouldn't quite work when all of the backgrounds are on the same element.

@samderanova
Copy link
Contributor Author

Most of the animations on Figma don't seem scroll related to me though, except maybe the fish swimming up the screen.

@taesungh
Copy link
Member

taesungh commented Dec 6, 2023

Perhaps it was discussed briefly during the first sync but never formally noted. We can reconsult graphics.

@tyleryy
Copy link
Contributor

tyleryy commented Dec 10, 2023

Screen Shot 2023-12-09 at 11 31 42 PM I think the decomposed background image border shows when you shrink the window.

@samderanova
Copy link
Contributor Author

Ok, I'll see if I can switch to a more fluid version of that background.

@tyleryy
Copy link
Contributor

tyleryy commented Dec 15, 2023

I might want to add a glTF Blender dragon so maybe it can fly through the layered background. So it could be useful to decouple the background assets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restyle landing section
4 participants