-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: separated landing background pictures #40
base: main
Are you sure you want to change the base?
Conversation
Deploy preview for irvinehacks-site-2024-sanity ready!
|
Deploy preview for irvinehacks-site-2024 ready!
|
…o update/landing-background
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm not seeing the benefit to the layered approach here: I thought the long term goal was having dynamic positioning of the pieces, but this stacked background doesn't make progress towards that. Mainly pointing this out since the asset size has dramatically increased to produce nearly the same end result. |
This is so we can eventually add on animations more easily. One of the animations, for example, is to have the boat slide up into the landing section on load. |
Hmm, animating the background position when there are so many backgrounds might be a bit cumbersome. Additionally, I thought the movement concepts would require some scroll-based parallax which wouldn't quite work when all of the backgrounds are on the same element. |
Most of the animations on Figma don't seem scroll related to me though, except maybe the fish swimming up the screen. |
Perhaps it was discussed briefly during the first sync but never formally noted. We can reconsult graphics. |
Ok, I'll see if I can switch to a more fluid version of that background. |
I might want to add a glTF Blender dragon so maybe it can fly through the layered background. So it could be useful to decouple the background assets. |
Resolves #30 . There's a slight issue where on larger viewpoints, the background (and thus, the color transition to the deep blue) get cut off. I'm currently trying to figure out how to fix this.