Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup basic landing page #5

Merged
merged 5 commits into from
Nov 5, 2023
Merged

Setup basic landing page #5

merged 5 commits into from
Nov 5, 2023

Conversation

samderanova
Copy link
Contributor

  • Customized PostCSS configuration to allow syntax similar to Sass (see Button.module.css)
  • Created favicon.ico
  • Imported necessary font and font colors
  • Created custom Button component
    • While the hover does work, I could not get the transition to work properly. The background color for it is actually a background image as it uses the radial-gradient property, so I used transition: background-image 1s ease, but this does not seem to have any effect.
  • Added basic landing page with a button that links to the form to subscribe to our mailing list

@samderanova samderanova linked an issue Nov 5, 2023 that may be closed by this pull request
Setup landing page #1
Closed
@samderanova samderanova requested a review from a team November 5, 2023 16:34
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2023 •
edited
Loading

Deploy preview for irvinehacks-site-2024 ready!

Name Hack at UCI Site
Preview Visit Preview
Commit d2c1b32

taesungh
taesungh reviewed Nov 5, 2023
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking alright from preview, small notes.

apps/site/src/components/Button/Button.tsx Outdated Show resolved Hide resolved
apps/site/src/components/Button/Button.tsx Outdated Show resolved Hide resolved
apps/site/src/app/globals.css Outdated Show resolved Hide resolved
apps/site/src/app/globals.css Show resolved Hide resolved
apps/site/src/app/(home)/sections/Landing/Landing.tsx Outdated Show resolved Hide resolved
taesungh
taesungh approved these changes Nov 5, 2023
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for now, thanks for the quick work under crunch.

@samderanova samderanova merged commit f725912 into main Nov 5, 2023
1 check passed
@taesungh taesungh mentioned this pull request Nov 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taesungh taesungh taesungh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup landing page
2 participants
@samderanova @taesungh