Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import SAML code from last year's website #59

Merged
merged 8 commits into from
Dec 6, 2023
Merged

Import SAML code from last year's website #59

merged 8 commits into from
Dec 6, 2023

Conversation

samderanova
Copy link
Contributor

@samderanova samderanova commented Dec 2, 2023 •
edited
Loading

Resolves #58 . Alongside importing SAML related code and tests, we also test if logging into this deployment works on previews.

@samderanova
feat: inital saml import
cc14145 
- Import SAML code (saml.py) from last year's code repository
- Include settings and public key certificates
@samderanova
update: pathlib and json load optimizations
7241bd2
@samderanova
feat: SAML pytest and pnpm test script
e3a7472 
- Import test SAML from last year's code repository
- Configure pytest to run on `pnpm test`
@samderanova
feat: import Serveless Function build script
4352759 
- Import vercel-lib.sh from last year's code repository to current
  repo's site code
- Update site code's vercel.json to run this script
@samderanova samderanova linked an issue Dec 2, 2023 that may be closed by this pull request
Import SAML backend from last year's website #58
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2023 •
edited
Loading

Deploy preview for irvinehacks-site-2024-sanity ready!

Name Sanity Studio
Preview Visit Preview
Commit 14c37b5

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2023 •
edited
Loading

Deploy preview for irvinehacks-site-2024 ready!

Name IrvineHacks 2024 Site
Preview Visit Preview
Commit 14c37b5

@samderanova
Copy link
Contributor Author

On preview deployments, logging in will redirect to our staging domain at https://staging.irvinehacks.com and on production deployments, will redirect us to our production domain. @taesungh and I are currently trying to get the staging domain working.

@taesungh
Copy link
Member

taesungh commented Dec 3, 2023

Note: Vercel currently thinks we do not own the irvinehacks.com domain, so we cannot manually assign any subdomains as an alias for a specific deployment (able to assign only to production). Tracking in vercel/discussions#5053.

@taesungh
Copy link
Member

taesungh commented Dec 3, 2023

Deployment alias was manually assigned using a direct POST request to Vercel's REST API endpoints as described in vercel/discussions#953.
SAML functionality can be tested at the login endpoint: https://staging.irvinehacks.com/api/saml/login

taesungh
taesungh approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the continued work on this. We'll handle issuing the user identity when importing the rest of the API.

@samderanova samderanova merged commit 7b457a8 into main Dec 6, 2023
2 checks passed
@taesungh taesungh deleted the setup/saml branch December 17, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyleryy tyleryy tyleryy approved these changes

@taesungh taesungh taesungh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import SAML backend from last year's website
3 participants
@samderanova @taesungh @tyleryy