-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up basic SendGrid Handler #73
Conversation
Deploy preview for irvinehacks-site-2024-sanity ready!
|
Deploy preview for irvinehacks-site-2024 ready!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also import the unit tests from test_sendgrid_handler.py
?
We'll also need the email_handler.py
at some point, not sure if you want to do that now or separately.
Currently working on both 👍 |
fefff62
to
2d0eaef
Compare
- Move `Template` enum from email_handler to sendgrid_handler - Include overloads to associate each SendGrid template with specific personalization data - Use overloads for `send_to_multiple` parameter which affects shape of provided `receiver_data`
…e-2024 into setup/sendgrid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for including stubs on this. Let's squash during merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgmt
Please do not merge this PR yet, as I am testing template sending using the Hack group account. Previously SendGrid is tied to a separate Hack account, but for some reason, sending emails from this account is not working correctly. I will update the template IDs when I get it working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgmt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rip account but I guess it's only reasonable when we're out of time.
This pull request includes a function that sends emails using SendGrid.
Required environment variables:
SENDGRID_API_KEY
: needed to use the SendGrid API. This has already been added to Vercel.