Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: application pydantic models #76

Merged
merged 4 commits into from
Dec 16, 2023
Merged

Conversation

samderanova
Copy link
Contributor

This pull requests adds the Pydantic models related to application data. A few changes were made to the code:

  • According to the application data, there are no word limits, so I removed max_length argument of the Field instances.
  • In utils.py, two parameters/attributes were deprecated/no longer existing, so I updated them to their respective current ones.

@samderanova samderanova linked an issue Dec 12, 2023 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Dec 12, 2023

Deploy preview for irvinehacks-site-2024-sanity ready!

Name Sanity Studio
Preview Visit Preview
Commit 07890ac

Copy link
Contributor

github-actions bot commented Dec 12, 2023

Deploy preview for irvinehacks-site-2024 ready!

Name IrvineHacks 2024 Site
Preview Visit Preview
Commit 07890ac

Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can go with these for now and then figure out if we need to adjust None vs empty string when actually connecting the application form submission.

Copy link
Contributor

@waalbert waalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samderanova samderanova merged commit 4a16231 into main Dec 16, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import application-related Pydantic models
3 participants