Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/landing page fireflies #8

Merged
merged 16 commits into from
Nov 11, 2023
Merged

Feature/landing page fireflies #8

merged 16 commits into from
Nov 11, 2023

Conversation

tyleryy
Copy link
Contributor

@tyleryy tyleryy commented Nov 7, 2023

@samderanova
Copy link
Contributor

samderanova commented Nov 7, 2023 •
edited
Loading

We should work on getting necessary content on the site first, so I won't be addressing this PR until after that. Also, moving forward, please create an issue before opening up a PR so that we know what you're working on.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2023 •
edited
Loading

Deploy preview for irvinehacks-site-2024 ready!

Name IrvineHacks 2024 Site
Preview Visit Preview
Commit 211427f

@tyleryy
Copy link
Contributor Author

tyleryy commented Nov 7, 2023

I agree we should work on the content first, and I plan to do so. I just wanted to do this really quick for the landing page. I imagine that our landing page will be up for awhile, so I wanted it to look good for any passing by hackers.

Old

Screen Shot 2023-11-06 at 7 34 23 PM

New

Screen.Recording.2023-11-06.at.7.41.20.PM.mov

@samderanova
Copy link
Contributor

Ah that's true, I see your point. I'll take a look when I can then 👍

samderanova
samderanova approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@samderanova samderanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for working on this. I think we should be able to use React Three instead of Framer for the fog though but we can discuss that in a separate issue.

@samderanova samderanova linked an issue Nov 10, 2023 that may be closed by this pull request
React Three Fiber Effects #9
Closed
samderanova
samderanova requested changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@samderanova samderanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turns out that this takes up quite a bit of memory. There's a native approach in Sass that we can try implementing first. See Blinkers.scss from an earlier version of ZotHacks.

@tyleryy
Copy link
Contributor Author

tyleryy commented Nov 10, 2023 •
edited
Loading

I did a Lighthouse scan on the site. I believe the performance is actually ok. I'm a bit new to web optimization and performance, so I may be wrong. Also, on my own machine, it took about 800 MB of memory, which is not awful.

I guess the trade off is the time and energy to implement the native approach vs performance. So is it worth of our time? This is just a design thing so it doesn't matter and could just be scrapped altogether.

Screen Shot 2023-11-10 at 3 08 57 PM Screen Shot 2023-11-10 at 3 09 18 PM Screen Shot 2023-11-10 at 3 09 41 PM Screen Shot 2023-11-10 at 3 10 24 PM

samderanova
samderanova requested changes Nov 11, 2023
View reviewed changes
Copy link
Contributor

@samderanova samderanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small suggestions/nitpicks:

apps/site/src/app/(home)/sections/Landing/Landing.tsx Outdated Show resolved Hide resolved
apps/site/src/components/canvas/Examples.tsx Outdated Show resolved Hide resolved
apps/site/src/components/dom/Layout.tsx Outdated Show resolved Hide resolved
apps/site/src/components/dom/Layout.tsx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 11, 2023 •
edited
Loading

Deploy preview for irvinehacks-site-2024-sanity ready!

Name Sanity Studio
Preview Visit Preview
Commit 211427f

samderanova
samderanova reviewed Nov 11, 2023
View reviewed changes
Copy link
Contributor

@samderanova samderanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more small question:

apps/site/src/components/canvas/View.tsx Outdated Show resolved Hide resolved
@tyleryy tyleryy merged commit 38e40fa into main Nov 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samderanova samderanova samderanova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

React Three Fiber Effects
2 participants
@tyleryy @samderanova