Set up user identity and JWT for native users #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Import `user_identity` auth, `user` router, and `user_record` util, and associated tests from last year's HackAtUCI/HackUCI-Site - Install python-jose[cryptography] - Add user router to app
- Ignore call-arg error when calling super constructor - `EmailStr` no longer needs to be explicitly constructed
- Replace `dict` with `model_dump` and `parse_obj` with `model_validate`
- Provide user identity cookie when authenticating with SAML ACS - Rename `hackuci_auth` to `irvinehacks_auth`
- Use `Annotated` for `Cookie` and `Union` instead of `Optional`
- `Optional` fields are no longer not required in Pydantic V2 models - Add unit test for `/user/me` endpoint
|
Deploy preview for irvinehacks-site-2024-sanity ready!
|
|
Deploy preview for irvinehacks-site-2024 ready!
|
samderanova
reviewed
Dec 15, 2023
samderanova
requested changes
Dec 15, 2023
taesungh
changed the title
- Add `pydantic.mypy` plugin to generate signature for `Model.__init__` - Do not enable `init_forbid_extra` option - This will type `super().__init__` with an extra `kwargs: Any` - Thus the type ignore in `NativeUser` can be removed
rileysw
approved these changes
Dec 15, 2023
samderanova
approved these changes
Dec 16, 2023
|
Please squash merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the user identity code from last year to provide JWTs when completing SAML authentication.
The full guest authentication flow will come separately with #68, but the user identity foundation is provided here, e.g. the
GuestUsermodel.Closes #69.
Changes
user_identityauth,userrouter, anduser_recordutil, and associated tests from last year's HackAtUCI/HackUCI-SiteJWT_SECRETcheck toindex.pyNativeUser,EmailStrEmailStrno longer needs to be explicitly constructeddictwithmodel_dumpandparse_objwithmodel_validatehackuci_authtoirvinehacks_authAnnotatedforCookieandUnioninstead ofOptionalIdentityResponsefor userOptionalfields are no longer not required in Pydantic V2 models/user/meendpointJWT_KEYlog_outtologoutfor consistencyTesting
Staging subdomain was manually assigned to the preview deployment. Confirmed SAML flow works and user identity cookie is provided which is properly consumed by
/api/user/meendpoint.