-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - Added FAQ section #157
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hacks-site into feature/add-faqs-from-sanity
Closed
Deploy preview for zothacks-site-2023 ready!
|
Deploy preview for zothacks-site-2023-sanity ready!
|
taesungh
reviewed
Oct 4, 2024
taesungh
reviewed
Oct 5, 2024
waalbert
reviewed
Oct 5, 2024
waalbert
reviewed
Oct 7, 2024
waalbert
reviewed
Oct 7, 2024
waalbert
reviewed
Oct 7, 2024
waalbert
reviewed
Oct 7, 2024
…tons, removed unnused variable
waalbert
reviewed
Oct 8, 2024
Your branch is 1 commit behind main, so can you merge main into your branch and see if there are anything that gets broken? |
…o feature/add-faqs-from-sanity
waalbert
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this Ian! Please squash and merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added FAQ section according to Figma design (minus the noodles at the ends of the speech bubbles)
I added Framer Motion as a dependency, so reinstall dependencies after merge.
Things:
Thought: On mobile view, the FAQ's seem really lengthy idk