Create intro and mentor sections #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for zothacks-site-2023-sanity ready!
|
|
Deploy preview for zothacks-site-2023 ready!
|
samderanova
force-pushed
the
feature/intro-and-mentor
branch
from
3fa141d
to
7f46b1b
Compare
|
Not sure if we need to handle these dimensions, but for mobile, it looks like the
|
|
The green sticky is meant to be under the yellow one as per the Figma. The curved yellow sticky won't work in the mobile view, but the green sticky being underneath the yellow one is something I attempted to preserve here. |
taesungh
requested changes
Sep 19, 2023
taesungh
reviewed
Sep 23, 2023
taesungh
reviewed
Sep 23, 2023
taesungh
reviewed
Sep 23, 2023
taesungh
reviewed
Sep 23, 2023
taesungh
reviewed
Sep 23, 2023
taesungh
reviewed
Sep 23, 2023
- Use pseudo-elements to construct extended chevron with borders - Use `bootstrap.button-variant` mixin for styles - Implement pulling effect with left padding transition - Add `translateZ(0)` to rotations to prevent rendering bugs in Safari
- Replace Bootstrap `Row` with `div` since container handles padding - Remove unused `useWindowWidth` reference
taesungh
reviewed
Sep 26, 2023
taesungh
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes:
As discussed with @taesungh , a flat yellow post-it for the mobile view was used instead of the curved one like in the wireframes, mainly because putting enough text will cause it to extend out of the bounds of the yellow sticky.