Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature mentor apply link #39

Merged
merged 8 commits into from
Oct 4, 2023
Merged

Feature mentor apply link #39

merged 8 commits into from
Oct 4, 2023

Conversation

tyleryy
Copy link
Contributor

@tyleryy tyleryy commented Oct 3, 2023

Overview

Added link to mentor application google form.


Reference to form here

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Deploy preview for zothacks-site-2023-sanity ready!

Name Sanity Studio
Preview Visit Preview
Commit 5208aa0

@tyleryy
Copy link
Contributor Author

tyleryy commented Oct 3, 2023

I also added a /mentor redirect route to the form. Let me know if this is desired behavior.

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Deploy preview for zothacks-site-2023 ready!

Name Hack at UCI Site
Preview Visit Preview
Commit 5208aa0

@tyleryy
Copy link
Contributor Author

tyleryy commented Oct 3, 2023

Actually, on the redirect, I noticed the web page renders empty first then redirects to the google form.

@tyleryy
Copy link
Contributor Author

tyleryy commented Oct 3, 2023

Blocked by apply link PR, will pull to get redirect urls once merged

Copy link
Contributor

@samderanova samderanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small issue and we're good to go! Thanks for working on this as well.

apps/site/src/app/mentor/page.tsx Show resolved Hide resolved
feat: added mentor app redirect route

fix: removed redirect route

update: added application link

fix: click opens new tab

feat: added apply redirect route

update: redirect in next config

fix: removed /home redirect + added /mentor redirect

update: changed button href to /apply

fix: switched mentor url to /mentor
@tyleryy
Copy link
Contributor Author

tyleryy commented Oct 4, 2023

Ready for Review!

@alexanderl19 alexanderl19 dismissed samderanova’s stale review October 4, 2023 18:54

Unnecessary file removed.

@alexanderl19 alexanderl19 self-requested a review October 4, 2023 18:54
@alexanderl19 alexanderl19 merged commit 31d56a1 into main Oct 4, 2023
2 checks passed
@taesungh
Copy link
Member

taesungh commented Oct 4, 2023

Force unmerged given messiness of tree, reopening as #43.

@taesungh taesungh deleted the feature-mentor-apply-link branch October 15, 2023 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants