-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature schedule maintenance #40
Conversation
Deploy preview for zothacks-site-2023 ready!
|
Deploy preview for zothacks-site-2023-sanity ready!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these images have a free license? Would prefer to stick with in-house graphics when possible. Additionally, prior convention is leaving out the schedule page entirely from Navigation, but open to having such a "coming soon" page if not too out of character.
Yea they have free license to use. I'll send it over slack @taesungh |
removed imports fix: removed coming soon image
image dimensions can be changed if fit |
…eature-schedule-maintenance
We'll be utilizing environment variables to control whether we show the resources and schedule pages or not. cc: @taesungh |
- Extract graphic and text to new `Maintenance` component
Working on it. |
- Show Maintenance view instead of page content when environment variable is set for Schedule and Resources page
Will need to add values for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for working on this. I also added the variables to Vercel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, let's squash merge.
Overview
Put Maintenance Image temporarily on schedule page until it is developed, for early site release.
left both images in for comparison as to which is better
maybe we can ask graphics to make a maintenance Petr?
we could also create an
error.tsx
file and have that render instead? I don't know if this is considered best practice or not.