Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature schedule maintenance #40

Merged
merged 14 commits into from
Oct 31, 2023
Merged

Conversation

tyleryy
Copy link
Contributor

@tyleryy tyleryy commented Oct 3, 2023

Overview

Put Maintenance Image temporarily on schedule page until it is developed, for early site release.

  • left both images in for comparison as to which is better

  • maybe we can ask graphics to make a maintenance Petr?

  • we could also create an error.tsx file and have that render instead? I don't know if this is considered best practice or not.

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Deploy preview for zothacks-site-2023 ready!

Name Hack at UCI Site
Preview Visit Preview
Commit 360c8bc

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Deploy preview for zothacks-site-2023-sanity ready!

Name Sanity Studio
Preview Visit Preview
Commit 360c8bc

Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these images have a free license? Would prefer to stick with in-house graphics when possible. Additionally, prior convention is leaving out the schedule page entirely from Navigation, but open to having such a "coming soon" page if not too out of character.

@tyleryy
Copy link
Contributor Author

tyleryy commented Oct 3, 2023

Yea they have free license to use. I'll send it over slack @taesungh
hand-drawn-construction-background.zip

@tyleryy
Copy link
Contributor Author

tyleryy commented Oct 4, 2023

image dimensions can be changed if fit

@samderanova samderanova requested a review from taesungh October 5, 2023 07:06
@alexanderl19 alexanderl19 marked this pull request as draft October 5, 2023 23:18
@tyleryy tyleryy closed this Oct 29, 2023
@tyleryy tyleryy reopened this Oct 29, 2023
@samderanova samderanova marked this pull request as ready for review October 31, 2023 02:15
@samderanova
Copy link
Contributor

We'll be utilizing environment variables to control whether we show the resources and schedule pages or not.

cc: @taesungh

@samderanova samderanova removed the request for review from taesungh October 31, 2023 02:17
- Extract graphic and text to new `Maintenance` component
@tyleryy tyleryy closed this Oct 31, 2023
@taesungh
Copy link
Member

Working on it.

@taesungh taesungh reopened this Oct 31, 2023
- Show Maintenance view instead of page content when environment
  variable is set for Schedule and Resources page
@taesungh
Copy link
Member

Will need to add values for MAINTENANCE_MODE_SCHEDULE and MAINTENANCE_MODE_RESOURCES to the Production environment in Vercel to show maintenance until we are ready to release.

Copy link
Contributor

@samderanova samderanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for working on this. I also added the variables to Vercel.

Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, let's squash merge.

@samderanova samderanova merged commit d1e4446 into main Oct 31, 2023
@taesungh taesungh deleted the feature-schedule-maintenance branch September 27, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants