rizan_ibrahim-browsers-w1-assingment #44
Conversation
rizan-ibrahim
changed the title
rizan-ibrahim
changed the title
There was a problem hiding this comment.
Rizan, great job on completing the exercises for Week 1 of the Browsers module! You've made good progress and implemented the required functionalities for the assignments. Most of the unit tests have passed, which shows a good understanding of the core concepts.
- ex1-bookList: The book list needs improvements. Images are not showing up at the moment. Try to build file paths for
srcdynamically by using relative path. You also need to add thealtattribute to the images, as indicated by the test failure. - ex2-aboutMe: You have correctly updated the spans with your personal information, and the list items are styled correctly with the class
list-itemin your CSS file. - ex3-hijackLogo: The Google logo is correctly replaced with the HackYourFuture logo by modifying the
srcandsrcsetproperties. - ex4-whatsTheTime: The time is correctly displayed and updates every second using
setInterval(). But it triggers every 100 ms. The load event listener is correctly used. - ex5-catWalk: The cat animation is working well, and the dancing cat appears in the middle before the original image is restored.
.test-summary/TEST_SUMMARY.md
Outdated
|
|
||
| | Exercise | Passed | Failed | ESLint | | ||
| |------------------|--------|--------|--------| | ||
| | ex1-bookList | 5 | 1 | ✕ | |
There was a problem hiding this comment.
Hi Ammar i didnt know exactly what was the mistake here but i will see it thanks for check
| const infoBook = document.createElement('p'); | ||
| infoBook.textContent = `${book.title} by ${book.author}`; | ||
| const imgBook = document.createElement('img'); | ||
| imgBook.src = `https://via.placeholder.com/100x150?text=${encodeURIComponent(book.title)}`; |
There was a problem hiding this comment.
Why do you need to use https://via.placeholder.com?
Can't you just achieve it via a relative path? You can use the relevant book title and build the file name.
There was a problem hiding this comment.
well u are right but i just want to try this way for practice since the traditional way is moe common than this
There was a problem hiding this comment.
I understand, but when I run the app locally, book images are not showing up. Can you fix it?
| } | ||
| window.addEventListener('load', () => { | ||
| addCurrentTime(); | ||
| setInterval(addCurrentTime, 100); |
There was a problem hiding this comment.
Tip
You trigger the addCurrentTime function every 100 milliseconds. Although the timer shows the correct time, it runs every 100 milliseconds, not every second (1000 milliseconds). This may negatively affect your app's performance.
There was a problem hiding this comment.
oh my bad i will fix it sure thanks for check
| // TODO complete this function | ||
| } | ||
| const cat = document.querySelector('img'); | ||
| let position = parseInt(cat.style.left, 10) || 0; |
No description provided.