Feras AL Demashki w1-usingAPIs-assignment #53
Conversation
There was a problem hiding this comment.
Hi @Feras-ALdemashki, overall well done! But there are some minor issues that I would like you to look at before I can approve your PR.
| reject(Error("You didn't pass in a first name!")); | ||
| } | ||
| }, 1000); | ||
| }); | ||
| }; | ||
|
|
||
| function main() { |
There was a problem hiding this comment.
When I run your code (using npm start rather than npm test) nothing is displayed any more in the console. Since you are now using promises you need to modify the main() function too.
There was a problem hiding this comment.
i have changed the main() function and checked the npm start its working now .
| @@ -1,3 +1,5 @@ | |||
| import { error } from '@actions/core'; | |||
There was a problem hiding this comment.
I assume this got inserted by VSCode by accident. Better get rid of it.
There was a problem hiding this comment.
i don't know what is this line is . now i removed it
| } | ||
|
|
||
| // ! Do not change or remove the code below | ||
| if (process.env.NODE_ENV !== 'test') { | ||
| main(); | ||
| } | ||
|
|
||
| // TODO Replace this comment by your explanation that was asked for in the assignment description. | ||
| // the previous problem is no longer exist. | ||
| // now we return the promise so the rolling will stop after the promise is resolved or rejected |
There was a problem hiding this comment.
Not quite. The rolling does not stop after a reject. The die continues to roll until it has completed its (randomly) assigned rolls. Can you improve your explanation?
There was a problem hiding this comment.
i have changed the explanation .
| @@ -43,4 +42,4 @@ if (process.env.NODE_ENV !== 'test') { | |||
| main(); | |||
| } | |||
|
|
|||
| // TODO Replace this comment by your explanation that was asked for in the assignment description. | |||
| // now we have 5 different promises, and each one is running as a different task in an async way . | |||
There was a problem hiding this comment.
Thanks, @Feras-ALdemashki. I can now approve your PR. Good luck with the week 2 assignment.
| getAnonName('John', console.log); | ||
| getAnonName('John') | ||
| .then((response) => console.log(response)) | ||
| .catch((error) => console.error(error.message)); |
| @@ -47,4 +47,4 @@ if (process.env.NODE_ENV !== 'test') { | |||
| } | |||
|
|
|||
| // the previous problem is no longer exist. | |||
| // now we return the promise so the rolling will stop after the promise is resolved or rejected | |||
| // because the promise only settle once , any other resolves or rejects will be ignored | |||
No description provided.