-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #5284: replace JSX.Element to React.ReactElement #5296
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!
What to expect from this code review:
- Comments posted to any areas of potential concern or improvement.
- Detailed feedback or actions needed to resolve issues that are found.
- Turnaround times vary, but we aim to be swift.
@yuki0410-dev you can click here to see the review status or cancel the code review job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PullRequest Breakdown
Reviewable lines of change
+ 90
- 79
100% TSX
Type of change
Fix - These changes are likely to be fixing a bug or issue.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5296 +/- ##
=======================================
Coverage 96.92% 96.92%
=======================================
Files 29 29
Lines 3377 3378 +1
Branches 1400 1417 +17
=======================================
+ Hits 3273 3274 +1
+ Misses 104 102 -2
- Partials 0 2 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The replacement of JSX.Element
with React.ReactElement
seems straightforward, and the two should be compatible when used in this way. I don't have any blocking concerns to bring up. Thanks!
Reviewed with ❤️ by PullRequest
Our last blocker for React 19 upgrade fixed, thank you 😊👍 |
Description
Linked issue: closes #5284
Problem
See issue
Changes
replace JSX.Element to React.ReactElement
Contribution checklist