Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added compatibility with repository TFS #242

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

froufe
Copy link

@froufe froufe commented May 30, 2016

Added compatibility with repository TFS that resolve the issue #230

Added new parameter in Config file "repositoryTFS" and functionality to do private bower compatible with TFS when the parameter have the value "true"

@Hacklone
Copy link
Owner

Hey,

Thanks for contributing.

Isn't simply registering the package without git+http:// enough?

Thanks,
Barna

@froufe
Copy link
Author

froufe commented May 30, 2016

Hi Barna,

Without git+http:// you get a Error 401 Unauthorized, and this is the way that I found to force the authentication for git repositories in TFS.

Best,
Cristobal

@Hacklone
Copy link
Owner

I'm sure I'm missing something here :)

What I see now is that you register the package with git+http://package then in every case you're using it you convert the url back to http://package, so why don't you register your package with http://package url so that you won't have to convert it every time?

When the parameter "repositoryTFS" repository is true, the registerPackages add the prefix "+git"
@froufe
Copy link
Author

froufe commented May 31, 2016

Apologies, I missed the last change. Now It's fixed.

If repositoryTFS is true the register package add "git+" for the action "clone", and when you see the url in the frontEnd or get the bower.json for the details works without "git+".

This functionality is not visible for the user. Then in this way for the user is only put the parameter "true".

Without this implementation you can register your package adding "git+" (the people must to know or investigate like me) and you can clone but you can´t see the details.

Let me know If you need more details

Best,
Cristobal

@Hacklone
Copy link
Owner

Hey,

Now I get it :)

The problem is that if you enable this option you won't be able to use github etc just your TFS server.
how about this solution:

  • when you register your TFS baseg package register it like this: tfs+git+http://package
  • detect this custom protocol and only replace these :)

This way no option flag is needed + you can use the private-bower with non TFS packages as well.

Thanks,
Barna

@froufe
Copy link
Author

froufe commented May 31, 2016

Hi,

Thanks for your replies, I think that is a good idea :)

I want to left my solution if you flag the option, because people like me only works with tfs and add your solution too. if the option is not flagged and you put the prefix tfs+git+http://package this will be replaced and you can works with TFS and Github together.

What do you think? I can do the changes.

We can decide for tfs+git+http://package or tfs+http://package. I think that the second make the prefix easier.

Please, let me know your opinion.

Best,
Cristobal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants