feat: add australia region support #258
Conversation
| @@ -45,20 +45,20 @@ const askForRegionInput = () => { | |||
| type: 'list', | |||
| name: 'region', | |||
| message: 'What Region are you in?', | |||
| choices: ['CN','US', 'EU', 'CA'], | |||
| choices: ['CN', 'US', 'EU', 'CA', 'AU'], | |||
There was a problem hiding this comment.
This is the only change in this file, everything else is from Prettier
| import { | ||
| EUDatedDriveHistory, | ||
| EUDriveHistory, | ||
| EUPOIInformation, | ||
| historyDrivingPeriod, | ||
| } from '../interfaces/european.interfaces'; |
There was a problem hiding this comment.
I reuse the European drive history interfaces here as it's identical. I also notice China's is identical too. Seems like China/Europe/Australia all basically share the same API and interfaces, so probably worth just pulling them into a shared interface?
bitnimble
force-pushed
the
bitnimble/add-australia-support
branch
from
3940e52 to
c8487d1
Compare
bitnimble
changed the title
| } | ||
| step: 0.5, | ||
| }, | ||
| // TODO: verify the Australian temp code ranges |
There was a problem hiding this comment.
I'm like 90% sure this is correct, but will need to validate more in the future with some other vehicles just in case.
|
Can you give this a test @bitnimble and we can I did just publish |
if all is working well.
|
Tested and working! It did generate a new CFB, but both the old and new ones work, so I'm not really sure what's up there... |
This PR adds support for Kia and Hyundai in Australia. It is largely a copy of the China + Europe authentication mechanisms, with some changes to the vehicle parser (seems like we get a little less information :'( )
I will probably look at consolidating the vehicle parsers at some stage now that we've hit ~3 identical implementations, but I need a bit more time actually using it to make sure that everything is correct.