Skip to content

Commit

Permalink
Warnings as errors on the CI
Browse files Browse the repository at this point in the history
This PR turns warnings into errors in the CI by adding a new profile `ci` in
`dune`.

I also remove the useless `warnings` profile.
  • Loading branch information
Halbaroth committed Oct 13, 2023
1 parent b553807 commit 3a49aa0
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ jobs:
- name: Install dependencies
run: opam exec -- make deps js-deps

- name: Run make
run: opam exec -- make
- name: Build the project
run: opam exec -- dune build --profile ci @check

- name: Monitor changes
uses: getsentry/action-git-diff-suggestions@main
Expand Down
4 changes: 2 additions & 2 deletions src/dune
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
(flags
(:standard -bin-annot -w -22 -warn-error -A))
(ocamlopt_flags -g))
(warnings ;; This profile can be used to simply enable all warnings.
(ci ;; This profile is used by the CI.
(flags
(:standard -bin-annot -w +A -warn-error -A))
(:standard -bin-annot -w -22 -warn-error +A))
(ocamlopt_flags -g))
(release ;; The release profile has optimizations enabled.
(flags
Expand Down

0 comments on commit 3a49aa0

Please sign in to comment.