Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jsonmenu): add new spoon #200

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

refnode
Copy link
Contributor

@refnode refnode commented Nov 9, 2020

Add new Spoon JSONMenu reading a list of menu items from a json file
and displays the entries in the macOS main menu bar.

Closes #192

Add new Spoon JSONMenu reading a list of menu items from a json file
and displays the entries in the macOS main menu bar.
@nonissue
Copy link

nonissue commented Nov 15, 2020

This is a really cool idea, but it requires the URLDispatcher spoon to be installed, and doesn't verify/install the dependency.

Edit:

Also, if the intention is only to provide functionality for opening websites, I think you could just avoid using URLDispatcher altogether and just use hs.urlevent.openURL(url)

@refnode
Copy link
Contributor Author

refnode commented Mar 10, 2021

Sry for the late response.
Great feedback and atm I only use it for opening web urls.
I'll try to make it merge ready asap when I have a free slot.

Using URLDispatcher as an option for advanced use cases could be extended later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[JSONMenu] Provide a Spoon to render menus based on JSON files
2 participants