-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spoon: Watch for meeting #228
base: master
Are you sure you want to change the base?
Conversation
Is
Not sure I understand why it's getting that warning... My documentation has those 3 parameters spelled out:
And they seem to all be there in docs.json |
Never mind, that was exactly why it was failing. Seems like that check is very picky about the formatting. Had to rewrite parameters as
And now we're passing. |
@asp55 sorry it’s so picky. I’m going to look into having the docstring checker leave specific comments on the PR to show where the problems are. Might make it easier for people to deal with. |
@cmsj No problem, I eventually got it. Though I'm not entirely sure what I fixed to clear the first set of warnings that claimed this about all my methods...
|
I don't think this check is failing because of something in my code. Or am I missing something? Failing check: Publish Docstring Annotations
|
@asp55 If you rebase this on top of current |
@cmsj yep, seems to be working now. |
Added a few new features to this spoon. |
Hi, checking in if this pull request is being considered. |
Submitting WatchForMeeting.spoon, which monitors for active zoom.us calls, and can share that information to a web page (that can in turn be run on a tablet outside the room to let others know you're busy.)