Update hotkey.lua: add isActive#3608
Open
muescha wants to merge 2 commits intoHammerspoon:masterfrom
Open
Conversation
add isActive
Contributor
Author
|
TODO:
|
Contributor
Author
|
i can not see why the test are failing :( |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Member
|
@muescha ignore the CI tests, they're horribly broken at the moment. I think this feature makes sense to add, so if you'd like to go ahead with it, I like your idea that an |
Contributor
Author
|
did you mean "hiding implementation" like this in 7e389a0
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3608 +/- ##
==========================================
+ Coverage 27.61% 27.63% +0.01%
==========================================
Files 180 191 +11
Lines 36181 43465 +7284
==========================================
+ Hits 9993 12012 +2019
- Misses 26188 31453 +5265 🚀 New features to boost your workflow:
|
Angel644-wep
approved these changes
Jan 13, 2026
| --- * If `key` is nil, no global hotkey will be registered (all other parameters will be ignored) | ||
| function hotkey.modal.new(mods, key, message) | ||
| local m = setmetatable({keys = {}}, hotkey.modal) | ||
| local m = setmetatable({keys = {}}, hotkey.modal) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add isActive
See: