Repository navigation
feat(site): draw the track chart with axes, gridlines and a hover readout - #70
Merged
Merged
Conversation
…dout Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The track page's cumulative-return chart had no value axis, no gridlines and oversized labels, so it read as a sketch: the reader could not tell what a line's height meant or what any day's values were.
Task (verbatim): none — untracked work
What changed
trackDrawinTRACK_JS) at the container's real width, so type stays 11px at any size and redraws on resize.Not changed: the series data, the stats row, the legend values.
Verification
Gate: ruff 0 errors in the committed tree · pytest 511/511 · f1c5c48
Red-first: test_chart_carries_its_series_and_labels_the_actual_benchmark written with the change, not watched red separately
Live: not run — drawn and driven (hover, toggle, 375px width) in a browser against the real latest track.json; the deployed site is not yet rebuilt
Not verified: older browsers without ResizeObserver or pointer events
Problems found
none
Follow-ups
none
Reviewer notes
Start here:
TRACK_JSand_track_chartinkuroshio/site/render.pyReproduce:
pytest tests/test_track.py -q🤖 Generated with Claude Code