chore: move envs variables to gh actions#917
Merged
Conversation
Deploying happychain with
|
| Latest commit: |
4b8a184
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c07e69e9.happychain.pages.dev |
| Branch Preview URL: | https://gabriel-move-envs-to-actions.happychain.pages.dev |
GabrielMartinezRodriguez
added
the
reviewing-1
norswap
added
reviewing-2
norswap
reviewed
Jun 14, 2025
| export MONITORING_DB_PATH=/home/randomness-monitor/monitor.sqlite | ||
| export RPC_URL=wss://rpc.testnet.happy.tech/ws | ||
| export CHAIN_ID=216 | ||
| export RANDOM_CONTRACT_ADDRESS=0xd7dafcdC292906540Cc3357E9fD913390256b978 |
Collaborator
There was a problem hiding this comment.
We should probably import from deployments for this.
norswap
approved these changes
Jun 14, 2025
Collaborator
norswap
left a comment
norswap
left a comment
There was a problem hiding this comment.
Nice! Next step is to prune the vars on github.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the environment variables to the GitHub Action for the following services:
Toggle Checklist
Checklist
Basics
norswap/build-system-caching).Reminder: PR review guidelines
Correctness
testnet, mainnet, standalone wallet, ...).
< INDICATE BROWSER, DEMO APP & OTHER ENV DETAILS USED FOR TESTING HERE >
< INDICATE TESTED SCENARIOS (USER INTERFACE INTERACTION, CODE FLOWS) HERE >
and have updated the code & comments accordingly.
Architecture & Documentation
(2) commenting these boundaries correctly, (3) adding inline comments for context when needed.
Public APIS and meaningful (non-local) internal APIs are properly documented in code comments.
in a Markdown document.
make changesetforbreaking and meaningful changes in packages (not required for cleanups & refactors).