Submitter: retry when the EVM nonce is too low#989
Merged
Conversation
…loop replacing an old nonce
norswap
changed the title
Deploying happychain with
|
| Latest commit: |
8257dfc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9cd35b25.happychain.pages.dev |
| Branch Preview URL: | https://ns-retry-future-nonce.happychain.pages.dev |
norswap
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this, we would attempt to replace (cancel) a transaction whose EVM nonce is too low, which is nonsensical and would always fail (but then work because the replacel logic would detect that the nonce is too low).
Now we immediately retry the operation (account creation or boop submit) when the nonce is too low, but only once, otherwise we fail, and we never go to replacement in this case.