Beginning of payment history database #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyGiorgio
reviewed
May 15, 2024
Comment on lines
27
to
65
| CREATE TABLE on_chain | ||
| ( | ||
| operation_id TEXT PRIMARY KEY NOT NULL, | ||
| fedimint_id TEXT NOT NULL REFERENCES fedimint (id), | ||
| address TEXT NOT NULL, | ||
| amount_sats BIGINT NOT NULL, | ||
| inbound INTEGER NOT NULL, | ||
| txid TEXT, | ||
| status INTEGER NOT NULL, | ||
| created_at TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP, | ||
| updated_at TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP | ||
| ); |
There was a problem hiding this comment.
It's worth considering splitting on chain deposits and on chain withdraws. Same with lightning too. It's been a pain in the ass trying to conform them both in mutiny.
You have a few things in both that are marked NOT NULL and those would be different based on whether it's a deposit or a withdraw.
|
ready for round 2 |
|
I think the structure is sound, should merge asap even if it doesn't hook in throughout yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Want some ACKs on the db schema before I go further. Even added some unit tests 👀