Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make 30 second db timeout for all tests #66

Merged
merged 1 commit into from
May 30, 2024
Merged

Make 30 second db timeout for all tests #66

merged 1 commit into from
May 30, 2024

Conversation

benthecarman
Copy link
Contributor

Closes #65

looks like this happens on people's local machines, better to just have the 30 second timeout for all tests instead of just CI

TonyGiorgio
TonyGiorgio approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@TonyGiorgio TonyGiorgio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need a better long term solution for detecting wrong password but this works.

@benthecarman benthecarman merged commit fd34615 into master May 30, 2024
2 checks passed
@benthecarman benthecarman deleted the test-timeout branch May 30, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonyGiorgio TonyGiorgio TonyGiorgio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Could not setup db: timed out waiting for connection
2 participants
@benthecarman @TonyGiorgio