[Draft] Keep ZR Waterfall open after playing once #4547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as make it togglable. - Added menu options - Added save variable - Added actor init and update hooks
|
To be honest, for what you were trying to accomplish here, I think you did quite well. No intrusion into src (although I would probably ask if the comments you added for documentation were pulled from decomp or if they had any equivalent there), using the appropriate hooks, etc. I still don't have a firm grasp on those hooks, but probably the only thing that would improve it is applying the dynamic registration/unregistration that's exhibited by other enhancements such that the hook doesn't get processed if the enhancement isn't enabled. Someone else would probably have to help you figure out how exactly to do that. |
serprex
reviewed
Nov 15, 2024
serprex
reviewed
Nov 15, 2024
serprex
reviewed
Nov 15, 2024
Co-authored-by: Philip Dubé <[email protected]>
…moved redundant checks.
|
With the one we were comparing this to merged, this can probably be closed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on this before seeing there was already a PR for it, but I decided to make a PR anyway for feedback. It is my first time messing with the game hooks and trying to make something following the project practices.
There are two options:
One makes it so that the waterfall keeps open after playing Zelda's Lullaby even after reloading the scene or the file.
The other appears if you selected the first and lets you close it up by playing the song again. It also persists through scenes and loading the file.
Enhancements>Gameplay>Timesavers
2024-11-14.18-41-42-1.mp4