-
Notifications
You must be signed in to change notification settings - Fork 613
Reafactor GenerateItemPool and Ice Trap settings #5773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we shouldn't negate .Is
calls with !
and instead use .IsNot
to avoid confusuion as the !
is easy to miss.
Imo, all switch statements should have defaults that assert to avoid us missing adding new cases in the future.
|
Refactors the item pool to fix numerous bugs, especially with Plentiful item pools, makes ship exclusive items affected by item pool, and changes ice trap settings to be more clear and consistent to the user.
Full change-list:
-- Base Ice Traps: whether or not the item pool's normal ice traps are in the pool. This on and nothing else is equivalent to the old "Normal" setting.
-- Ice trap Count: A fixed number of additional ice traps, added at the same point as the base pool
-- Ice trap Percent: The chance for each junk item to be replaced with an Ice trap. Does not affect Lesser items. Setting this to 100 is the equivalent of Onslaught.
I have not been able to test this fully so please test various odd settings combinations and check the item pool to make sure everything is in proper counts. Plandomiser's "empty all locations" button is good for this.
Build Artifacts