Load metadata without LoadFile() on startup
#5817
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement file type entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decouples file metadata loading from the LoadFile flow, thus allowing for the
saveBlockandgSaveContextto be untouched on startup and resets. As this completely avoids both of those now, some testing to make sure there aren't unintended consequences of having zeroed data for both of those before slot loading is probably warranted.This also implements the
fileTypefield in the save block, which is then used to determine old randomizer status rather than checking all the vanilla block fields. The newStartupCheckAndInitMeta()function, which is called in theSram_Init()chain, also now houses that and the build version checks.Build Artifacts