Add the - type: InitRepairSnapshot component to ships to make SRD work#1024
Open
Generic-Eagle wants to merge 3 commits intoHardLightSector:masterfrom
Open
Add the - type: InitRepairSnapshot component to ships to make SRD work#1024Generic-Eagle wants to merge 3 commits intoHardLightSector:masterfrom
Generic-Eagle wants to merge 3 commits intoHardLightSector:masterfrom
Conversation
Contributor
Author
|
Also this won't fix any existing ships, those would need some way to get the component added. |
Contributor
Author
|
Exclusions due to lack of becomestation component: |
Contributor
Author
|
Sooo seems that because we are missing monos walls.yml, walls are unable to be repaired using this. I asked AL if I should fix this by putting the information needed on the base upstream files, and he said "Idfk" soooo ready for review |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

About the PR
This PR aims to make the SRD work at the bare minimum.
Not sure how this works with saving but that's something I can test, same with building onto a ship and trying to repair that when it breaks.
At the creation of the PR, every HL exclusive ship has the component minus two that do not even have becomestation, so that's a whole other bridge (Sojourn and Herzyn)
Changelog
🆑 Generic_Eagle