Skip to content

Fix MWE combining acute accent parser issue #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arthurian merged 2 commits into from
Jul 31, 2025
Merged

Fix MWE combining acute accent parser issue #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a8078e
bugfix: fixed MWEs with accents not being tokenized correctly
arthurian Jul 31, 2025
f730c1d
lint: reformattd with ruff
arthurian Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions parser_tool/tests/test_tokenizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,36 @@ def test_tokenize_sentence_with_multi_word_expression(self):
"text": "Во время встречи он встал и вышел в коридор. В это время мы еще не поняли, в чем дело.",
"occurrences": 1,
},
{
"mwe": "Во-первых",
"text": "Во-первых, нужно понять суть проблемы.",
"occurrences": 1,
},
{
"mwe": "Во-вторых",
"text": "Во-вторых, следует найти решение.",
"occurrences": 1,
},
{
"mwe": "В-третьих",
"text": "В-третьих, нужно проверить результат.",
"occurrences": 1,
},
{
"mwe": "Во-первы́х",
"text": "Во-первы́х, это очень важно.",
"occurrences": 1,
},
{
"mwe": "Во-вторы́х",
"text": "Во-вторы́х, нужно быть осторожным.",
"occurrences": 1,
},
{
"mwe": "В-тре́тьих",
"text": "В-тре́тьих, это последний пункт.",
"occurrences": 1,
},
]
for test in tests:
(mwe, text, expected_occurrences) = test["mwe"], test["text"], test["occurrences"]
Expand Down
5 changes: 4 additions & 1 deletion parser_tool/tokenizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,10 +276,13 @@ def split_hyphenated(tokens, hyphen_char=HYPHEN_CHAR, reserved_words=HYPHENATED_
"""
Splits hyphenated tokens, handling special cases like "по-" words, which should not be split.
"""
# Create a set of canonical forms of reserved words for faster lookup
canonical_reserved_words = {canonical(word) for word in reserved_words}

new_tokens = []
for token in tokens:
# split hyphenated unless it's a special case like "по-" words (DB entries for those)
if hyphen_char in token and not token.startswith("по-") and token not in reserved_words:
if hyphen_char in token and not token.lower().startswith("по-") and canonical(token) not in canonical_reserved_words:
for t in re.split(r"(%s)" % hyphen_char, token):
if t != "":
new_tokens.append(t)
Expand Down