feat(dynamic-transaction-model): nc actions fees#1406
Merged
raul-oliveira merged 1 commit intomasterfrom Oct 9, 2025
Merged
Conversation
|
| Branch | raul-oliveira/charge-nc-actions-fee |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.96 m(+13.96%)Baseline: 1.72 m | 1.55 m (78.97%) | 2.07 m (94.97%) |
8a73968 to
7927601
Compare
5b9105b to
97b8620
Compare
97b8620 to
4020caa
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1406 +/- ##
==========================================
- Coverage 85.94% 85.94% -0.01%
==========================================
Files 434 434
Lines 33675 33739 +64
Branches 5278 5291 +13
==========================================
+ Hits 28943 28996 +53
- Misses 3686 3696 +10
- Partials 1046 1047 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
glevco
requested changes
Sep 17, 2025
glevco
reviewed
Sep 17, 2025
2 tasks
77e824b to
d5f069d
Compare
4020caa to
70da0b2
Compare
381d3d4 to
a3954f6
Compare
726b60c to
e50732b
Compare
msbrogli
requested changes
Oct 8, 2025
msbrogli
previously approved these changes
Oct 8, 2025
glevco
previously approved these changes
Oct 8, 2025
90a31ea to
79f329e
Compare
glevco
requested changes
Oct 8, 2025
1 task
79f329e to
b207594
Compare
glevco
approved these changes
Oct 8, 2025
msbrogli
approved these changes
Oct 9, 2025
jansegre
approved these changes
Oct 9, 2025
Contributor
Author
We discussed this point and @glevco addressed it in the #1451 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on 1350
Motivation
According to the RFC documentation, withdraw and deposit actions involving fee tokens must pay a fee.
Actions execute before contract execution and accept a token ID, which can be generated deterministically. When an action receives a
token_uidthat has not yet been created (called acreate_tokensyscall), it's not possible to determine the version of that token, and therefore calculate the fee.Aiming to bring balance consistency during nano contract execution, we are introducing the
NCFee.Acceptance Criteria
NCFeearray containing atoken_uidandamountto inform which token will be used to pay fees.feesis exact the same required for the operations to runpaid_feesdict which contains all the fees paid by inter contract calls (nc x nc)paid_feesare deposit based or HTRChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged