refactor: remove MinerJob defaults to prevent resource exhaustion#1604
Merged
refactor: remove MinerJob defaults to prevent resource exhaustion#1604
Conversation
|
| Branch | refactor/miner-job-defaults |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.61 m(-6.23%)Baseline: 1.71 m | 1.54 m (95.98%) | 2.05 m (78.14%) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1604 +/- ##
==========================================
- Coverage 85.67% 85.65% -0.02%
==========================================
Files 439 439
Lines 33618 33618
Branches 5282 5282
==========================================
- Hits 28802 28796 -6
- Misses 3801 3806 +5
- Partials 1015 1016 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
msbrogli
approved these changes
Feb 25, 2026
jansegre
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
After running multiple processes that use hathor-core and crash, it's possible that hathor-core will stop working because of leaked resources that are not cleaned up. This happens because of
multiprocessingresources that are initialized on module level. The fix is to move them to runtime.To be clear, this is harmless on most environments, but I caught it while working on integration with Rust.
Acceptance Criteria
MinerJobfrom module-level to runtime.Below is a traceback when the resources are exhausted:
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged