Open
Conversation
|
| Branch | feat/hathorlib-blueprint-move-2 |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.60 m(-6.61%)Baseline: 1.71 m | 1.54 m (96.37%) | 2.05 m (77.82%) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1606 +/- ##
==========================================
- Coverage 85.65% 85.54% -0.11%
==========================================
Files 439 439
Lines 33515 33171 -344
Branches 5264 5218 -46
==========================================
- Hits 28707 28377 -330
+ Misses 3797 3783 -14
Partials 1011 1011
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
To be able to implement the blueprint simulator on hathorlib there is a significant amount of code that needs to be moved from
hathor/tohathorlib/.Since moving this amount of code can cause instabilities we are breaking down these changes into more manageable and reviewable PRs.
This is the second PR in this sequence.
Acceptance Criteria
Extra context
Important note about HathorError: After analysis,
except HathorErrorappears in 5 places in hathor-core (vertex_handler, api_catch_exceptions, p2p sync clients, hello state). However,NCFailexceptions NEVER reach these catch blocks because:block_executor.py:391catchesexcept NCFailand wraps it inNCExecutionFailure- NC exceptions never escape the block executor.nano_header_verifier.py:177,196catchesNCFailand converts toNCTxValidationError(TxValidationError, NCFail), which inherits fromHathorErrorthroughTxValidationError. So by the time errors reachvertex_handler.py:214, they AREHathorErrorsubclasses.except BlueprintDoesNotExist), not throughHathorError.Therefore, the simple re-export (where hathorlib's
NCFailinherits fromExceptiononly) is safe. The re-export strategy works without needingNCFailto also inherit fromHathorError.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged